HttpClient: Adds optimization to avoid double buffering response #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
kirankumarkolli,
kirillg and
sboshra
as code owners
govenkat-ms
reviewed
Sep 3, 2020
magole
reviewed
Sep 3, 2020
ealsur
approved these changes
Sep 4, 2020
kirankumarkolli
approved these changes
Sep 11, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
If you set HttpClient request to use
HttpCompletionOption.ResponseContentReadthen HttpClient will buffer the response. The response is then copied over to a memory stream causing it to create another buffer. This change sets all request toHttpCompletionOption.ResponseHeadersRead. This way HttpClient does not buffer the content.Type of change
Please delete options that are not relevant.
Closing issues
closes #1828