Blazor: Fixes not supported HTTP features #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
approved these changes
Sep 21, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Creation of the
CosmosHttpClienttries to set the Proxy and MaxConnectionsPerServer properties onHttpClientHandler, but these are not supported on all platforms.This fix conditionally attempts to set them and detects
PlatformNotSupportedExceptionand retries without these parameters.Due to the nature of the issue, no mocking can be done to test it.
Testing was done with a real Blazor WASM application.
Type of change
Closing issues
Closes #1860
Closes #1862