HttpClient: Fixes HttpResponseMessage.RequestMessage is null in WASM #1875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HttpClient on WebAssembly seems to behave a bit differently than in NET Core/FX. When doing a
SendAsync
, the resultingHttpResponseMessage
does not have theRequestMessage
property set to the originatingHttpRequestMessage
.During Cache operations, if the operation fails with, for example, a 404, GatewayStoreClient will use
GatewayStoreClient.CreateDocumentClientExceptionAsync
to parse theHttpResponseMessage
, and use theRequestMessage
property to get the original Url, but this triggers aNullReferenceException
in WASM (see linked Issue).This PR makes sure to set the property in the
CosmosHttpClient
if the property is null after callingSendAsync
.Type of change
Closing issues
Closes #1873