Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Adds AuthorizationHelper improvements #1879

Merged
merged 6 commits into from
Sep 27, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Sep 25, 2020

Pull Request Template

Description

UrlEncode the constant parts of the authorization header to avoid doing it for every call.

Roughly
14% improvement in runtime for CreateSignatureGeneration and ReadSignatureGeneration
12.5% decrease in memory for ReadSignatureGeneration and 7% decrease in memory for CreateSignatureGeneration

|                       Method |     Mean |     Error |    StdDev |    StdErr |      Min |       Q1 |   Median |       Q3 |      Max |      P80 |      P85 |      P90 |      P95 |     P100 |      Op/s |  Gen 0 | Gen 1 | Gen 2 | Allocated | Completed Work Items | Lock Contentions |
|----------------------------- |---------:|----------:|----------:|----------:|---------:|---------:|---------:|---------:|---------:|---------:|---------:|---------:|---------:|---------:|----------:|-------:|------:|------:|----------:|---------------------:|-----------------:|
|    CreateSignatureGeneration | 1.769 us | 0.0134 us | 0.0196 us | 0.0036 us | 1.731 us | 1.759 us | 1.767 us | 1.785 us | 1.804 us | 1.785 us | 1.785 us | 1.788 us | 1.799 us | 1.804 us | 565,381.9 | 0.1297 |     - |     - |     816 B |               0.0000 |                - |
|      ReadSignatureGeneration | 1.750 us | 0.0294 us | 0.0432 us | 0.0080 us | 1.674 us | 1.718 us | 1.745 us | 1.776 us | 1.862 us | 1.777 us | 1.780 us | 1.803 us | 1.832 us | 1.862 us | 571,551.0 | 0.1240 |     - |     - |     784 B |               0.0000 |                - |
| CreateSignatureGenerationOld | 2.077 us | 0.0397 us | 0.0569 us | 0.0108 us | 2.012 us | 2.036 us | 2.057 us | 2.115 us | 2.224 us | 2.129 us | 2.135 us | 2.157 us | 2.187 us | 2.224 us | 481,348.5 | 0.1373 |     - |     - |     880 B |               0.0000 |                - |
|   ReadSignatureGenerationOld | 2.053 us | 0.0125 us | 0.0187 us | 0.0034 us | 2.019 us | 2.035 us | 2.056 us | 2.066 us | 2.097 us | 2.068 us | 2.068 us | 2.070 us | 2.081 us | 2.097 us | 487,085.1 | 0.1411 |     - |     - |     896 B |               0.0000 |                - |

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@kirankumarkolli kirankumarkolli merged commit 8e7ef28 into master Sep 27, 2020
@kirankumarkolli kirankumarkolli deleted the users/jawilley/perf/aad_const branch September 27, 2020 16:28
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants