Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINQ: Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync #1940

Merged
merged 8 commits into from Oct 28, 2020
Merged

LINQ: Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync #1940

merged 8 commits into from Oct 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2020

Pull Request Template

Description

CosmosLinqQuery.AggregateResultAsync takes a CancellationToken that is not propagated when reading the results from the FeedIterator

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@ghost ghost changed the title Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync Internal LINQ: Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync Oct 17, 2020
@bchong95 bchong95 changed the title Internal LINQ: Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync LINQ: Honor CancellationToken in CosmosLinqQuery.AggregateResultAsync Oct 19, 2020
Copy link
Contributor

@bchong95 bchong95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! good catch :)

@j82w
Copy link
Contributor

j82w commented Oct 19, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 20, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 23, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 23, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 26, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Oct 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w j82w merged commit 53f4535 into Azure:master Oct 28, 2020
@ghost ghost deleted the fix/cancellation-token branch October 28, 2020 18:30
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants