Performance: Adds optimized request headers #1949
Conversation
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
Microsoft.Azure.Cosmos/src/Headers/CosmosMessageHeadersInternal.cs
Outdated
Show resolved
Hide resolved
…com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/perf/request_headers
|
What's the E2E impact? From the attached chart reads are more optimal compared to creates. Does that fit well into the overall requirements? |
Please see the updated PR description. |
j82w
changed the title
j82w
changed the title
|
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
This uses a generated file to create a list of well known headers for Item point operations. This allows the properties to be directly set instead of doing a dictionary lookup.
This makes CosmosMessageHeadersInternal a contract which then has custom implementation for request headers and response headers.
Overall +50 to 100 Rps improvement for read item stream operations
*Create is just creating the object
*Read is object creation + adding all the headers used for a normal read scenario
*Keys is used in transport layer to iterate and populate the transport objects
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber