Control Plane Hot Path: Adds more aggressive timeout and retry logic #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for control plane hot paths.
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
bchong95
reviewed
Oct 23, 2020
bchong95
suggested changes
Oct 23, 2020
ealsur
previously approved these changes
Oct 23, 2020
bchong95
previously approved these changes
Oct 26, 2020
added 2 commits
October 29, 2020 05:03
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/http/transientRetries
j82w
changed the title
j82w
changed the title
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/http/transientRetries
…/transientRetries
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/http/transientRetries
…/transientRetries
ealsur
reviewed
Dec 2, 2020
FabianMeiswinkel
previously approved these changes
Dec 2, 2020
ealsur
previously approved these changes
Dec 15, 2020
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyControlPlaneHotPath.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyControlPlaneRead.cs
Outdated
Show resolved
Hide resolved
added 3 commits
December 16, 2020 10:01
…/transientRetries
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/http/transientRetries
added 2 commits
December 16, 2020 12:41
ealsur
approved these changes
Dec 17, 2020
This was referenced Dec 23, 2020
j82w
added a commit
that referenced
this pull request
Dec 28, 2020
PR #1954 only did retries on get operations. Get query plan is a post causing it to not do the faster retries. This adds explicit test to verify the behavior and to prevent future regression. The diagnostics was updated to always include the retry policy to help trouble shoot issues in the future.
1 task
|
Closing due to in-activity, pease feel free to re-open. |
Merged
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Non-hotpath (Account information)
Read:
5 second timeout (No delay on first retry)
10 second timeout
20 second timeout
Hotpath (QueryPlan, partition key ranges, address refresh)
Read retry in the same region. Does not impact region failover:
.5 second timeout (No delay on first retry)
5 second timeout
10 second timeout
All other operations use the current default of 65 seconds.
Tests are still in progress.
Type of change
Please delete options that are not relevant.
Closing issues
closes #1872 #1912