Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosClientOptions and ClientBuilder: Fixes ArgumentException when setting null value on HttpClientFactory or WebProxy #1960

Merged
merged 6 commits into from
Oct 26, 2020
Merged

CosmosClientOptions and ClientBuilder: Fixes ArgumentException when setting null value on HttpClientFactory or WebProxy #1960

merged 6 commits into from
Oct 26, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Oct 23, 2020

Pull Request Template

Description

This fixes the following issues:

  1. Previously WebProxy would get set even if an argument exception was thrown
  2. Setting a null value caused an ArgumentException which is not necessary for null values.
  3. WebProxy can now be set without being in gateway mode like HttpClientFactory. It's possible users want custom HttpClient settings even when in direct mode because control plane operation like Database and Container still go through HttpClient.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

closes #1953

@j82w j82w added the bug Something isn't working label Oct 23, 2020
@j82w j82w merged commit 1e09a4d into master Oct 26, 2020
@j82w j82w deleted the users/jawilley/bug/clientBuilder branch October 26, 2020 15:07
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@bchong95 bchong95 Awaiting requested review from bchong95

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CosmosClientBuilder ArgumentException with HTTP Client Factory and Gateway connection mode.
2 participants
@j82w @kirankumarkolli