TokenCredentialCache: Fixes timeout logic and ports tests from master #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
added
bug
ealsur
reviewed
Oct 30, 2020
ealsur
reviewed
Oct 30, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAadTests.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Oct 30, 2020
ealsur
approved these changes
Oct 30, 2020
j82w
added a commit
that referenced
this pull request
Nov 5, 2020
…#1972) * TokenCredentialCache: Fixes timeout logic and ports tests from master
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This ports test from CosmosDB master repo. This fixes the TokenCredentialCache to use the CosmosClient request timeout setting, and fixes bug with background refresh.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber