-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Feed Processor: Adds support for EPK leases #2013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
bchong95,
FabianMeiswinkel and
j82w
as code owners
November 17, 2020 22:15
j82w
reviewed
Dec 14, 2020
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedPartitionKeyResultSetIteratorCore.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/Bootstrapping/PartitionSynchronizerCore.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/Bootstrapping/PartitionSynchronizerCore.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLeaseConverter.cs
Show resolved
Hide resolved
...zure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLeaseDisabledConverter.cs
Outdated
Show resolved
Hide resolved
j82w
previously approved these changes
Dec 14, 2020
j82w
approved these changes
Dec 14, 2020
Closing due to in-activity, pease feel free to re-open. |
This was referenced Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for leases that represent a range of partition values and the wiring into the internal FeedProcessor to execute the Change Feed read based on the type of lease acquired by the Host.
The default lease schema is maintained as the current one (identified as Version 1) that maps 1 lease to 1 physical partition for backward compatibility with existing lease stores and V2 CFP.
When an event that affects the current partition (such as a partition Merge) happens, the current lease is migrated to the new schema.
This new schema versioning also prepares CFP to support decoupling the number of partitions from the number of leases, which will eventually let users define a higher degree of parallelization.
Lease schema difference
The current default (coming from V2 CFP) schema looks like:
The new range based lease's schema is:
Code changes details
ChangeFeedPartitionKeyResultSetIteratorCore
which now can set the EPK filter headers for leases that represent a range.Type of change