-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Charge: Fixes request charges for offers and CreateIfNotExists APIs #2041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a UT on the containerCore/DatabaseCore that mocks the ClientContext and simulates scenarios like the Conflict path, and ensures the resulting RU charge is always the sum of all the mocked responses?
This could also be done using the request handler to inject the 409. |
I added this via the handler logic in the latest iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
This fixes bugs where the operation requires multiple requests to the service to complete one user request. This fixes offers, CreateDatabaseIfNotExists and CreateContainerIfNotExists. Tests are added to prevent future regressions.
Added a additional check to the TransportHandler which verifies that does a warning trace if RequestChargeTracker is greater than the response. RequestChargeTracker is not used for gateway calls.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber