Diagnostics: Adds operation name to summary #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2020 11:18
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
added 2 commits
December 7, 2020 12:42
…Azure/azure-cosmos-dotnet-v3 into users/jawilley/diagnostics/name
kirankumarkolli
approved these changes
Dec 8, 2020
ealsur
pushed a commit
that referenced
this pull request
Dec 17, 2020
* Add operation name to diagnostics * nits * Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This adds the operation name to the diagnostics. This will make it easier in the future to troubleshoot issues.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber