CosmosException: Fixes substatuscode to get the correct value instead of 0 when it is not in the enum. #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
ealsur
reviewed
Jan 7, 2021
| @@ -108,7 +93,7 @@ internal static class CosmosExceptionFactory | |||
|
|
|||
| return CosmosExceptionFactory.Create( | |||
| responseMessage.StatusCode, | |||
| (int)responseMessage.Headers.SubStatusCode, | |||
There was a problem hiding this comment.
On a happy path (not exception), the ResponseMessage.Headers.SubStatusCode also has the same issue, right?
There was a problem hiding this comment.
Correct, but that is a internal field. If you are programming against the enum it makes since that it would use the default if you gave it value that wasn't supported by the enum.
j82w
changed the title
kirankumarkolli
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The document client exception that is thrown internally will return default value if the SubStatusCode is not defined in the enum. This changes the logic to parse and use the int from the headers so the exception always shows the correct value. This allows the SDK to properly handle unexpected or newer substatuscodes that it is not aware of.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber