-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Preview] Change Feed: Adds Full Fidelity support #2122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
January 13, 2021 22:26
j82w
previously approved these changes
Jan 19, 2021
j82w
reviewed
Jan 19, 2021
FabianMeiswinkel
previously approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Matias - thanks!
FabianMeiswinkel
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
j82w
approved these changes
Feb 1, 2021
kirankumarkolli
approved these changes
Feb 2, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the APIs to support Change Feed in Full Fidelity mode. Building on top of the Retention API exposed at #2020 and #2109, once a container has been created with Change Feed retention, Change Feed iterators can be created with Full Fidelity.
Full Fidelity Change Feed exposes creates, replaces, delete operations, including metadata.
The PR exposes a new
ChangeFeedMode
as a required parameter to initiate any Change Feed iterator. This prompts the user to make a conscious choice of the mode they want to use.Current Change Feed (the one available until now) is called
ChangeFeedMode.Incremental
, while the new one is calledChangeFeedMode.FullFidelity
.Creating a container with retention
Starting an incremental Change Feed (normal Change Feed)
or
Starting a Change Feed with Full Fidelity
or
The document payload available during Full Fidelity responses includes the
_metadata
attribute which contains the context information (likeoperationType
).Type of change