-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosClient: Adds CreateAndInitializeAsync Method #2197
Conversation
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientCreateAndInitializeTest.cs
Show resolved
Hide resolved
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientCreateAndInitializeTest.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some questions and suggestions, non-blocking, but might be worth thinking about them.
#else | ||
internal | ||
#endif | ||
static async Task<CosmosClient> CreateAndInitializeAsync(string accountEndpoint, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replicating one for each CTOR is good if we can avoid in future.
…zure/azure-cosmos-dotnet-v3 into users/askagarw/ClientColdStart
Hello, how would this work with the newly added Always Encrypted as .WithEncryption() returns a new client. |
Pull Request Template
Description
Adds a CreateAndInitializeAsync method in CosmosClient. This creates a new client and initializes the containers provided by warming up the caches and connections
Closes: #1706
Sample