Preview ChangeFeed: Fixes headers on failure path. #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Feb 15, 2021
Microsoft.Azure.Cosmos/src/Pagination/NetworkAttachedDocumentContainer.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Feb 16, 2021
Microsoft.Azure.Cosmos/src/Pagination/NetworkAttachedDocumentContainer.cs
Show resolved
Hide resolved
|
Please add UT coerage. |
ealsur
reviewed
Feb 16, 2021
Microsoft.Azure.Cosmos/src/Pagination/NetworkAttachedDocumentContainer.cs
Show resolved
Hide resolved
vivekr20
approved these changes
Feb 19, 2021
…tps://github.com/Azure/azure-cosmos-dotnet-v3 into users/brchon/ChangeFeed/AddHeadersOnResponsePath
sboshra
approved these changes
Feb 20, 2021
vivekr20
added a commit
that referenced
this pull request
Feb 22, 2021
- This test validates the changes made in the following PR: #2218 - Adding this test in place so that the contract does not regress.
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Preview ChangeFeed: Fixes headers on failure path.
Some headers were missing. In the future we need a generic ResponseMessage to CosmosException utility method.