Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerBuilder : Adds public Constructor to create ContainerBuilder instance. #2241

Merged
merged 7 commits into from
Mar 22, 2021

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented Feb 19, 2021

Description

This PR exposes a public ContainerBuilder constructor which would allow in this case Encryption Package to return a EncryptionContainer object.

    /// <summary>
    /// Creates an instance of ContainerBuilder .
    /// </summary>
    /// <param name="database"> The Microsoft.Azure.Cosmos.Database object.</param>
    /// <param name="name"> Azure Cosmos container name to create. </param>
    /// <param name="partitionKeyPath"> The path to the partition key. Example: /partitionKey </param>
    public ContainerBuilder(
        Database database,
        string name,
        string partitionKeyPath)

This would allow calls to DefineContainer to return an EncryptionContainer object.

public override ContainerBuilder DefineContainer(string name, string partitionKeyPath)
{
}
will return a ContainerBuilder , by passing EncryptionDatabase to ContainerBuilder which would allow us to return EncryptionContainer when calls come over to CreateContainerAsync() overriden in EncryptionDatabase to return EncryptionContainer object.

Type of change

  • [] New feature (non-breaking change which adds functionality)
  • [] This change requires a documentation update

@kr-santosh kr-santosh changed the title ClientBuilder : Adds public Constructor to create ClientBuilder instance. ContainerBuilder : Adds public Constructor to create ContainerBuilder instance. Feb 19, 2021
@kr-santosh kr-santosh closed this Feb 19, 2021
@kr-santosh kr-santosh reopened this Feb 19, 2021
@kr-santosh kr-santosh marked this pull request as ready for review February 19, 2021 09:59
@j82w j82w merged commit 8703a87 into master Mar 22, 2021
@j82w j82w deleted the users/sakulk/makevirtualbuilder branch March 22, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants