CosmosException: Fixes the headers not matching CosmosException property values #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
ealsur
reviewed
Feb 27, 2021
ealsur
approved these changes
Feb 27, 2021
nichatur
approved these changes
Feb 27, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change ensures that the values in the Headers and CosmoseException properties are always the same even if the header is updated. The header are mutable and would be out of sync with the CosmosException properties.
Fixes a bug where the CosmosException headers could possibly be null. This has caused null ref exception because users always assume it is there.
CosmosException would sometime record the substatus code as default 0. This was caused by a different bug which prevented the value from being parsed by the enum value. This changes the to string logic to directly use the header value to always capture it even if it is not a valid enum value.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber