PermissionProperties: Fixes ContainerInlineCore dependency from PermissionProperties #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asketagarwal
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
asketagarwal
changed the title
j82w
reviewed
Mar 1, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosPermissionTests.cs
Show resolved
Hide resolved
j82w
reviewed
Mar 1, 2021
Microsoft.Azure.Cosmos/src/Resource/Settings/PermissionProperties.cs
Outdated
Show resolved
Hide resolved
…movingInlineCoreDependencyPermissionProperties
ealsur
reviewed
Mar 1, 2021
Microsoft.Azure.Cosmos/src/Resource/Settings/PermissionProperties.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Mar 2, 2021
j82w
deleted the
users/askagarw/RemovingInlineCoreDependencyPermissionProperties
branch
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR removes ContainerInlineCore dependency from PermissionProperties.
Closing issues
To automatically close an issue: closes #2266