Exception-less Streaming API for non-existing NP container scenarios #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kirankumarkolli
requested review from
simplynaveen20,
visridha,
j82w,
ausfeldt and
ealsur
j82w
reviewed
May 10, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemTests.cs
Show resolved
Hide resolved
Few proxy methods from ExecUtils are removed.
j82w
approved these changes
May 10, 2019
simplynaveen20
approved these changes
May 10, 2019
kirankumarkolli
changed the title
kirankumarkolli
added a commit
that referenced
this pull request
May 10, 2019
…227) * First cut of fix * Refreshing syntax as per C#7 * ComosContextCore depenency on ExecUtils removed. Few proxy methods from ExecUtils are removed.
kirankumarkolli
added a commit
that referenced
this pull request
May 12, 2019
* added new system strings (#210) * Ignoring TestLazyIndexAllTerms (#211) * PartitionedCRUDTest ignored (#217) * Exception-less Streaming API for non-existing NP container scenarios (#227) * First cut of fix * Refreshing syntax as per C#7 * ComosContextCore depenency on ExecUtils removed. Few proxy methods from ExecUtils are removed. * SDK version to 3.0.0.11-preview and Direct dependency to 3.0.0.27-preview * Cherry pick 15a9e26 into 3.0.0.11_preview (#235) * Query routing with partition key definition (#213) * Fix breaks for the release * Remove unused usings * Adding a unit test to verify setting PartitionKeyDefinition works. (#226) * More * Fixes for query pipeline * Some more fixes * Np tests and quarantine open-partition tests * small correction * Direct contract test pruning * Few test fixes * Bug fix for paramaterised queries * Including NP query tests * One more test fix * Fix for MixedModeTypoes unit test * MixedMode multi-targeting tests clean. * Enabling Distinct and TopOrderBy for NP. * Quarantine TestQueryCrossPartitionAggregateFunctionsWithMixedTypes
kirankumarkolli
added a commit
that referenced
this pull request
May 12, 2019
* Raising version to 22-preview * Merge master into release (CF Pull internal API) (#115) * Assemblyinfo clean-up (#104) * Signed build assembly info fix * Assembly info clean-up * Including test projects internal visible to (#107) * Stand By Feed and ChangeFeed pull model (#105) * Adding initial files * Using Etag for continuation * Removing unused * Refactoring to reduce variables * Refactoring to use CompositeToken * Adding feed test * Refactor through Options * Adding public methods and comments * Routing through the point transport handler * Moving to outer if * Adding split logic * Adding unit tests * Adding logic to detect invalid continuation tokens * Adding JSON validation * Routing based on PKRangeId * Renaming and adding more tests * Moving logic into the token * Forcing refresh on split * Addressing final coments * Addressing feedback * Added test to cover CT passing * Refactoring and adding pkrangedelegate * Argument checks * Moving contract to CosmosRequestMessage * Refactoring make EnsureInitialized async * Moving tests to a new file * Adding PKrange assert * Refactored back to parameters outside Options * UT split * Adding Start* checks * Adding new tests and renames * Addressing comments * Refactoring for cache tests * Adding comments to tests * Adding factory method * Addressing comments * Refactoring PKRange outside options * Addressing comments * Removing StartFromBeginning * Removing extra lines * Removing unnecessary ToList * Raising version to 22-preview (#113) * fix bugs * Fixing signing issue * Hot fixes for CosmosSerializationOptions and query partition key issues (#207) * Hot fixes for CosmosSerializationOptions and query partition key. * initial commit (#193) * Fixed formatting * added new system strings (#210) * Ignoring TestLazyIndexAllTerms (#211) * PartitionedCRUDTest ignored (#217) * Exception-less Streaming API for non-existing NP container scenarios (#227) * First cut of fix * Refreshing syntax as per C#7 * ComosContextCore depenency on ExecUtils removed. Few proxy methods from ExecUtils are removed. * SDK version to 3.0.0.11-preview and Direct dependency to 3.0.0.27-preview * Cherry pick 15a9e26 into 3.0.0.11_preview (#235) * Query routing with partition key definition (#213) * Fix breaks for the release * Remove unused usings * Adding a unit test to verify setting PartitionKeyDefinition works. (#226) * More * Revert "Fixing samples build break (#236)" This reverts commit cda8903. * Force samples to Nuget.org only * Fixes for query pipeline * Some more fixes * Np tests and quarantine open-partition tests * small correction * Direct contract test pruning * Few test fixes * Bug fix for paramaterised queries * Including NP query tests * One more test fix * Fix for MixedModeTypoes unit test * MixedMode multi-targeting tests clean. * Enabling Distinct and TopOrderBy for NP. * Quarantine TestQueryCrossPartitionAggregateFunctionsWithMixedTypes * Test fixes. * BadRequestException fixes * Owner attribute removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
CreateItemStreamAsync targeting a NP collection with NonePartitionKeyValue should not throw exception. Expected to return status code.
Currently for partitioned collection its returning 404 and will return the same.
For GA we should make it 424 (Dependency failure) instead for dis-disambiguate it.
Type of change
ExecUtils moved to the path of deprecation. Related changes moved to RequestInvokerHandler
RequestInvokerHandler made primary entry contract for client
Fixed a bug introduced with FI from master, where cached ContainerSettings are not used.
Bug fix (non-breaking change which fixes an issue)
Closing issues
closes #233