Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes COUNT(DISTINCT) in V3 SDK by upgrading Direct package version #2282

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

neildsh
Copy link
Contributor

@neildsh neildsh commented Mar 8, 2021

Pull Request Template

Description

This change upgrades the Direct package so that we can use the new functionality in ServiceInterop.dll to enable the proper computation of COUNT(DISTINCT) in the V3 SDK.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"

Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@neildsh neildsh changed the title Direct package upgrade and enable COUNT(DISTINCT) in V3 SDK [Internal] Query: Direct package upgrade and enable COUNT(DISTINCT) in V3 SDK Mar 8, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"

Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@neildsh neildsh changed the title [Internal] Query: Direct package upgrade and enable COUNT(DISTINCT) in V3 SDK [Internal] Query: Fixes COUNT(DISTINCT) in V3 SDK by upgrading Direct package version Mar 8, 2021
@github-actions github-actions bot dismissed stale reviews from themself March 8, 2021 03:50

All good!

@neildsh neildsh changed the title [Internal] Query: Fixes COUNT(DISTINCT) in V3 SDK by upgrading Direct package version Query: Fixes COUNT(DISTINCT) in V3 SDK by upgrading Direct package version Mar 8, 2021
sboshra
sboshra previously approved these changes Mar 12, 2021
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit 3eebc5f into master Mar 22, 2021
@sboshra sboshra deleted the users/ndeshpan/dcount branch March 22, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants