CosmosException : Fixes exception messages to remove JSON formatting #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
sourabh1007
changed the title
sourabh1007
force-pushed
the
users/sourabhjain/errorjson
branch
2 times, most recently
from
f1feaab
to
5bebb38
Compare
j82w
reviewed
Mar 15, 2021
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Mar 15, 2021
....Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Performance.Tests/Contracts/BenchmarkResults.json
Show resolved
Hide resolved
j82w
reviewed
Mar 15, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosExceptionTests.cs
Outdated
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/errorjson
branch
from
38f454f
to
2f3c338
Compare
…eptionFactory.cs Co-authored-by: j82w <j82w@users.noreply.github.com>
sourabh1007
force-pushed
the
users/sourabhjain/errorjson
branch
from
09a2825
to
ed27f14
Compare
sourabh1007
changed the title
j82w
approved these changes
Mar 17, 2021
j82w
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
j82w
changed the title
ealsur
approved these changes
Mar 17, 2021
ealsur
pushed a commit
that referenced
this pull request
Mar 18, 2021
…2303) * CosmosException : Fixes exception messages by removing escape character * Update benchmark results * Update Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs Co-authored-by: j82w <j82w@users.noreply.github.com> * Code review Changes - 1 * Code Review Changes - 2 Co-authored-by: Sourabh Jain <sourabhjain@microsoft.com> Co-authored-by: j82w <j82w@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate over Error JSON and create message in string format with keys and their corresponding values.
Type of change
Closing issues
To automatically close an issue: closes #2255