ITrace: Fixes concurrency of cache. #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Mar 16, 2021
| using System.IO; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using Microsoft.Azure.Cosmos.Json; | ||
|
|
||
| internal static partial class TraceWriter | ||
| { | ||
| private static readonly Dictionary<string, string> FilePathToName = new Dictionary<string, string>(); | ||
| private static readonly ConcurrentDictionary<string, string> FilePathToName = new ConcurrentDictionary<string, string>(); |
There was a problem hiding this comment.
Let's avoid regressing this, please add a test using concurrent tasks.
There was a problem hiding this comment.
A test would also discover any other thread-unsafe operations that could be happening.
ealsur
pushed a commit
that referenced
this pull request
Mar 18, 2021
Co-authored-by: Samer Boshra <sboshra@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITrace: Fixes concurrency of cache.
Description
Makes the cache concurrent.