-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadMany: Adds ReadManyItems Api using Query under the covers #2352
Conversation
|
||
List<ResponseMessage> pages = new List<ResponseMessage>(); | ||
FeedIteratorInternal feedIterator = (FeedIteratorInternal)this.container.GetItemQueryStreamIterator( | ||
new FeedRangeEpk(partitionKeyRange.ToRange()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is crafty, good one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only points are around the semaphore wait that Kiran already pointed out
…ure-cosmos-dotnet-v3 into users/askagarw/readmany
…ure-cosmos-dotnet-v3 into users/askagarw/readmany
// Only allow 'maxConcurrency' number of queries at a time | ||
await semaphore.WaitAsync(); | ||
|
||
ITrace childTrace = trace.StartChild("Execute query for a partitionkeyrange", TraceComponent.Query, TraceLevel.Info); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do PKRangeId show up in the trace-data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, query adds the PKRangeIds
Sample
Stream:
Typed:
Closing issues
To automatically close an issue: closes #IssueNumber