Query: Fixes incorrect RequestCharge and missing headers in FeedResponse for ordered cross-partition queries #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccurrens
requested review from
bchong95,
j82w,
kirankumarkolli and
sboshra
as code owners
bchong95
previously approved these changes
Mar 31, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
Mar 31, 2021
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
ccurrens
force-pushed
the
orderby-crosspartition
branch
from
f7f781f
to
7622574
Compare
ccurrens
requested review from
ealsur,
FabianMeiswinkel,
khdang and
kirillg
as code owners
ccurrens
commented
Apr 1, 2021
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
ccurrens
commented
Apr 1, 2021
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/SkipEmptyPageQueryPipelineStage.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
neildsh
reviewed
Apr 9, 2021
.../Microsoft.Azure.Cosmos.Tests/Query/Pipeline/OrderByCrossPartitionQueryPipelineStageTests.cs
Outdated
Show resolved
Hide resolved
|
I would also recommend adding a test to Microsoft.Azure.Cosmos\tests\Microsoft.Azure.Cosmos.EmulatorTests\Query\OrderByQueryTests.cs that verifies request charges. You can try with:
|
|
Let me know if the test added to |
ccurrens
commented
Apr 13, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/QueryTestsBase.cs
Show resolved
Hide resolved
|
/azp run |
neildsh
reviewed
Apr 14, 2021
.../Microsoft.Azure.Cosmos.Tests/Query/Pipeline/OrderByCrossPartitionQueryPipelineStageTests.cs
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Apr 14, 2021
.../Microsoft.Azure.Cosmos.Tests/Query/Pipeline/OrderByCrossPartitionQueryPipelineStageTests.cs
Show resolved
Hide resolved
neildsh
previously approved these changes
Apr 14, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ccurrens
commented
Apr 14, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/OrderByQueryTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2357 in repo Azure/azure-cosmos-dotnet-v3 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…'s results are returned
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
neildsh
reviewed
Apr 15, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/OrderByQueryTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/QueryTestsBase.cs
Show resolved
Hide resolved
neildsh
previously approved these changes
Apr 15, 2021
neildsh
approved these changes
Apr 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This commit changes the
OrderByCrossPartitionQueryPipelineStageto pass along theAdditionalHeadersproperty from the current enumerator to the page result.Type of change
Closing issues
closes #2356