-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Availability: Fixes CancellationToken evaluation during failover #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
April 12, 2021 20:07
j82w
previously approved these changes
Apr 12, 2021
j82w
previously approved these changes
Apr 19, 2021
kirankumarkolli
previously approved these changes
Apr 20, 2021
j82w
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CancellationTokens, it is currently possible that a cancelling token stops the SDK from triggering the failover mechanics and marking a region unavailable if the token is canceled inbetween.
In a normal failover scenario, a request might face certain errors (HttpRequestException, 403.3, 403.1008, etc) which would trigger the retry policies. In these cases, the retry policy would mark the region unavailable and retry the request.
If a user provided a CancellationToken that canceled right after the error happened, the flow was checking the token status before initiating the failover process.
In this case, the client could be stuck because the token is preventing the SDK from failing over and new requests would face the same fate.
For example:
The ideal flow, which this PR addresses, is:
We had several policies that were checking the token before applying, which are fixed also in the same PR.
Tests
The PR adds an integration test that mimics what happens in a TCP timeout scenario when the token cancels during the address refresh, which is what happens when a region goes offline:
Type of change