Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosDiagnostics: Adds optimizations and BELatency #2397

Merged
merged 9 commits into from
Apr 19, 2021
Merged

CosmosDiagnostics: Adds optimizations and BELatency #2397

merged 9 commits into from
Apr 19, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Apr 15, 2021

Pull Request Template

Description

  1. BELatency is now included in point operation statistics
  2. StoreResult is now in json format
  3. Removed caller info on Handler because it's the base class so it doesn't help
  4. Removed Datum and child property if it they are empty
  5. Removed component ownership as it is not reliable. For example the latency can be labeled transport, but the issue is the query is really slow.

Closing issues

To automatically close an issue: closes #IssueNumber

ealsur
ealsur previously approved these changes Apr 16, 2021
View reviewed changes
@j82w j82w dismissed stale reviews from kirankumarkolli and ealsur via 9a0fcf0 April 19, 2021 14:28
@j82w j82w merged commit ae3e299 into master Apr 19, 2021
@j82w j82w deleted the users/jawilley/iTrace/beLatency branch April 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@ealsur ealsur ealsur left review comments

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j82w @ealsur @kirankumarkolli