Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct: Adds direct version 3.19 which includes improvements and fixes #2400

Merged
merged 8 commits into from
Apr 19, 2021
Merged

Direct: Adds direct version 3.19 which includes improvements and fixes #2400

merged 8 commits into from
Apr 19, 2021

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Apr 16, 2021 •
edited by j82w
Loading

  1. Bump direct version from 3.18.0 to 3.19.0
  2. wire up new API change for StoreReader and StoreReaderTest
  3. wire up new API change for adding rntbdMaxConcurrentOpeningConnectionCount

Adds:

  • Improved allocations on Direct/TCP

Fixes:

  • Fixed race condition in direct + tcp mode causing SDK generated internal server errors and invalid operation exceptions
  • Fixed race condition in direct + tcp mode causing unnecessary connections to be created by concurrent requests

closes #2370

github-actions[bot]
github-actions bot previously requested changes Apr 16, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@xinlian12 xinlian12 changed the title bump direct version and wire up Direct: Adds direct package 3.19.0 and wire up SYNFloodFix Apr 16, 2021
@github-actions github-actions bot dismissed their stale review April 16, 2021 21:58

All good!

@ealsur ealsur changed the title Direct: Adds direct package 3.19.0 and wire up SYNFloodFix Connectivity: Fixes flow for creation of TCP connections Apr 16, 2021
@j82w j82w changed the title Connectivity: Fixes flow for creation of TCP connections Availability: Fixes direct mode bug causing to many connections to be created concurrently Apr 17, 2021
@kirankumarkolli
Copy link
Member

How about changing the title to the line of "Limiting the concurrent connections creations per ednpoint ..."?

@j82w j82w changed the title Availability: Fixes direct mode bug causing to many connections to be created concurrently Direct: Add direct version 3.19 which includes multiple fixes Apr 19, 2021
github-actions[bot]
github-actions bot previously requested changes Apr 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

github-actions[bot]
github-actions bot previously requested changes Apr 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@j82w j82w changed the title Direct: Add direct version 3.19 which includes multiple fixes Direct: Adds direct version 3.19 which includes multiple fixes Apr 19, 2021
github-actions[bot]
github-actions bot previously requested changes Apr 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@github-actions github-actions bot dismissed stale reviews from themself April 19, 2021 14:00

All good!

@j82w j82w changed the title Direct: Adds direct version 3.19 which includes multiple fixes Direct: Adds direct version 3.19 which includes improvements and fixes Apr 19, 2021
kirankumarkolli
kirankumarkolli previously requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annie has similar changes, please sync with her

@xinlian12 xinlian12 merged commit f2b547e into master Apr 19, 2021
@xinlian12 xinlian12 deleted the users/xinlian/bumpDirectVersion branch April 19, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@j82w j82w j82w approved these changes

@github-actions GitHub Actions GitHub Actions left review comments

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@xinlian12 @kirankumarkolli @ealsur @j82w