Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes native c# parser grammar for recognizing string literal #2450

Merged
merged 9 commits into from
Jun 22, 2021

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 10, 2021

Pull Request Template

Description

This PR adds the fix in the grammar where the parser was having trouble recognizing string literal containing single quotes. It also fixes a bug where the parser was not correctly parsing LIKE with ESCAPE

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #2177 and #2178

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@leminh98 leminh98 changed the title [Internal][Query] Parser fix for recognizing string literal [Internal] Query: Fixes parser grammar for recognizing string literal May 10, 2021
@github-actions github-actions bot dismissed their stale review May 10, 2021 05:22

All good!

@j82w j82w changed the title [Internal] Query: Fixes parser grammar for recognizing string literal Query: Fixes native c# parser grammar for recognizing string literal May 10, 2021
@sboshra
Copy link
Contributor

sboshra commented May 10, 2021

K_UDF : U D F;

'udf'


Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Parser/sql.g4:213 in e67fee9. [](commit_id = e67fee9, deletion_comment = False)

sboshra
sboshra previously approved these changes May 10, 2021
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit 41a3769 into master Jun 22, 2021
@sboshra sboshra deleted the users/leminh/FixForSingleQuotationMark branch June 22, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos Sql parser : IN / NOT IN operator parsing fails for array of values
2 participants