-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Fixes native c# parser grammar for recognizing string literal #2450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
...smos.Tests/BaselineTest/TestBaseline/ScalarExpressionSqlParserBaselineTests.ObjectCreate.xml
Show resolved
Hide resolved
...smos.Tests/BaselineTest/TestBaseline/ScalarExpressionSqlParserBaselineTests.ObjectCreate.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Template
Description
This PR adds the fix in the grammar where the parser was having trouble recognizing string literal containing single quotes. It also fixes a bug where the parser was not correctly parsing LIKE with ESCAPE
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #2177 and #2178