AsyncCache: Fixes the cache to remove values if generator throws an exception #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngallardo
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
May 29, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
approved these changes
Jun 2, 2021
j82w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Implement logic within AsyncCache to immediately remove entries from the cache when the generator function throws an exception. These cache entries are effectively ignored today anyways, as subsequent retrievals simply execute the newly provided generator function. Without this change, AsyncLazy instances are cached for a potentially indefinite amount of time. In some services, this manifests as a slow memory leak as the exception objects gradually accumulate over time in the cache.
Type of change
Please delete options that are not relevant.
Closing issues
closes #2514