Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadMany: Fixes AddRequestHeaders request option and missing headers and message on failure scenarios. #2567

Merged
merged 2 commits into from
Jun 21, 2021
Merged

ReadMany: Fixes AddRequestHeaders request option and missing headers and message on failure scenarios. #2567

merged 2 commits into from
Jun 21, 2021

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented Jun 21, 2021 •
edited by j82w
Loading

Description

  1. Fixes custom headers via AddRequestHeaders in ReadManyRequestOptions
  2. Fixes the ResponseMessage in failure scenarios to have the exception and headers.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

@kr-santosh kr-santosh changed the title ReadMany: Adds support to pass custom header via ReadManyRequestOptions and fixes ResponseMessage returned. ReadMany: Adds support to pass custom headers via ReadManyRequestOptions and fixes ResponseMessage returned. Jun 21, 2021
@kr-santosh kr-santosh marked this pull request as ready for review June 21, 2021 11:56
@j82w j82w changed the title ReadMany: Adds support to pass custom headers via ReadManyRequestOptions and fixes ResponseMessage returned. ReadMany: Adds support to pass custom headers via ReadManyRequestOptions and fixes missing headers and message on ResponseMessage failure scenarios. Jun 21, 2021
@j82w j82w changed the title ReadMany: Adds support to pass custom headers via ReadManyRequestOptions and fixes missing headers and message on ResponseMessage failure scenarios. ReadMany: Fixes ReadMany AddRequestHeaders and missing headers and message on failure scenarios. Jun 21, 2021
@j82w j82w changed the title ReadMany: Fixes ReadMany AddRequestHeaders and missing headers and message on failure scenarios. ReadMany: Fixes AddRequestHeaders request option and missing headers and message on failure scenarios. Jun 21, 2021
FabianMeiswinkel
FabianMeiswinkel approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j82w j82w merged commit 275e020 into master Jun 21, 2021
@j82w j82w deleted the users/sakulk/fixHdrReadMulti branch June 21, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@asketagarwal asketagarwal asketagarwal approved these changes

@ealsur ealsur Awaiting requested review from ealsur

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@abhijitpai abhijitpai Awaiting requested review from abhijitpai

@anujtoshniwal anujtoshniwal Awaiting requested review from anujtoshniwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kr-santosh @j82w @FabianMeiswinkel @asketagarwal