LINQ : Fixes ArgumentNullException while calling ToQueryDefinition() #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
sourabh1007
changed the title
j82w
reviewed
Jun 29, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemLinqTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 29, 2021
sourabh1007
force-pushed
the
users/sourabhjain/toQueryDefinitionBug
branch
from
aea06fc
to
31e832e
Compare
j82w
reviewed
Jun 29, 2021
sourabh1007
force-pushed
the
users/sourabhjain/toQueryDefinitionBug
branch
2 times, most recently
from
dd06805
to
98b3534
Compare
sourabh1007
force-pushed
the
users/sourabhjain/toQueryDefinitionBug
branch
from
98b3534
to
708d4b0
Compare
sourabh1007
force-pushed
the
users/sourabhjain/toQueryDefinitionBug
branch
from
708d4b0
to
1f75a48
Compare
j82w
reviewed
Jun 29, 2021
j82w
previously approved these changes
Jun 29, 2021
j82w
approved these changes
Jun 30, 2021
ealsur
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes ArguementNullException in ToQueryDefinition for read feed scenarios where there has been no filters applied to the linq query.
Type of change
Closing issues
To automatically close an issue: closes #1438