Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Fixes memory leak on Windows x64 using ServiceInterop.dll #2827

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Query: Fixes memory leak on Windows x64 using ServiceInterop.dll #2827

merged 4 commits into from
Oct 28, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Oct 27, 2021 •
edited
Loading

Pull Request Template

Description

Fixes a memory leak in the service interop by bumping the direct version.

Includes a cherry picks:
Fix the emulator tests
Fix the performance tests

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

ealsur
ealsur previously approved these changes Oct 27, 2021
View reviewed changes
@j82w
It seems the backend is blocking the request because it is not encryp…
8e66c8f 
…ted. The test is expecting it to pass. I pin (#2824)

Two tests are failing with latest emulator. I updated ItemPatchFailureTest to use the new message.

EncryptionPatchItem is being ignored to unblock gates. It's being tracked: #2823
@sourabh1007
[Internal] Benchmark Tests: Adds 0.13.1 version for BenchmarkDotnet (#…
eebd198 
…2819)

Performances tests are failing consistently on gates so upgrading benchmark version which is compatible with .Net5 and has memory diagnoser fixes.

This switches the job from a medium to short to prevent the gates from timing out.
@j82w j82w merged commit 2f98cbd into releases/3.22.1 Oct 28, 2021
@j82w j82w deleted the users/jawilley/releases/3.22.1 branch October 28, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@ealsur ealsur ealsur left review comments

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j82w @ealsur @kirankumarkolli @sourabh1007