CosmosClientBuilder: Fixes accountEndpoint not being set when using TokenCredential #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levimatheri
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ealsur
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
added 2 commits
October 29, 2021 12:19
|
Commenter does not have sufficient privileges for PR 2844 in repo Azure/azure-cosmos-dotnet-v3 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ealsur
approved these changes
Oct 29, 2021
j82w
approved these changes
Oct 29, 2021
|
@j82w Any info on next release? Thanks |
|
The next release is currently waiting on some change to the service to be completed. Which will likely be in 2 to 3 weeks. Is there any reason you can't use the non-builder as a temporary workaround? |
|
That's alright. We have some options we pass thru the builder, e.g. custom serializer that are easier with the builder, we'll evaluate whether we can do with the non-builder otherwise we'll just wait till the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Bug fix: AccountEndpoint was not being set when using
CosmosClientBuilderwithTokenCredential. Introduced in 2753.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #2843