Performance: Adds query improvement to avoid ImmutableDictionary #2861
Conversation
sourabh1007
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
sourabh1007
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
This reverts commit b6da5a4cd9f3d960f2db749d930d4804c31750d9.
sourabh1007
force-pushed
the
users/sourabhjain/queryperffix1
branch
from
79ffee3
to
794d4a7
Compare
Description
Changed
AdditionalHeadersvariable type toIReadOnlyDictionaryfromImmutableDictionaryin order to avoid the creation on this object on every call unnecessarily.Fixes 1 of the 3 issues: #2815
Performane Test Result (Without this change):
Performane Test Result (With this change):
As you see above screenshots, Memory allocation has been reduced to 0-.2%.
Type of change