Benchmark: Adds the config to the run summary #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
ealsur
reviewed
Dec 1, 2021
sourabh1007
reviewed
Dec 1, 2021
ealsur
previously approved these changes
Dec 2, 2021
ealsur
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The run summary before was only including a subset of the configs. This makes it difficult to determine if a regression was caused by a change in the config. The run summary will now include the full config which ignores secret fields. This way if new configs get added they will automatically get logged with each run.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber