CosmosDiagnostics: Removes ITrace Caller Info and makes the Dictionary for Data lazy #2988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trace library always creates a CallerInfo object. This adds overhead to both collecting the trace and the CosmosDiagnostic.ToString() logic. There has been no use case for this information so it should be removed until there is a scenario.
IReadOnlyDictionary should be created lazily. In most traces no data is being added. A static singleton could be used by default.
The object removed:
Closing issues
To automatically close an issue: closes #2972