Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Encryption: Adds Client Encryption APIs to GA SDK #3035

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

anujtoshniwal
Copy link
Contributor

This reverts commit b73ed61.

Pull Request Template

Description

Need this to GA the client-encryption feature.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

abhijitpai
abhijitpai previously approved these changes Feb 16, 2022
kr-santosh
kr-santosh previously approved these changes Feb 16, 2022
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had arch board review with the Azure Central team yesterday for the Java version of the library. There was some feedback that needs further discussion with them and is relevant across Java and .Net (mostly how to expose way for crypto algorithms and how to wrap/unwrap keys) - please hold this PR until we have a clear way forward there (because it could impact public surface area)

Naveen will follow-up on this

@anujtoshniwal
Copy link
Contributor Author

Hi @FabianMeiswinkel, @j82w, @kirankumarkolli, now that the feedback has been addressed, please help review and close on this PR. Thanks!

abhijitpai
abhijitpai previously approved these changes Mar 8, 2022
@kr-santosh kr-santosh self-requested a review March 8, 2022 14:57
kr-santosh
kr-santosh previously approved these changes Mar 8, 2022
kirankumarkolli
kirankumarkolli previously approved these changes Mar 9, 2022
@j82w j82w changed the title Revert #2826: Refactors to add Client Encryption APIs to GA SDK Client Encryption: Adds Client Encryption APIs to GA SDK Mar 9, 2022
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@j82w j82w enabled auto-merge (squash) March 9, 2022 19:49
@j82w j82w merged commit e9aa0dd into master Mar 10, 2022
@j82w j82w deleted the users/antoshni/encryptionGA branch March 10, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants