-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Encryption: Adds Client Encryption APIs to GA SDK #3035
Conversation
This reverts commit b73ed61.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had arch board review with the Azure Central team yesterday for the Java version of the library. There was some feedback that needs further discussion with them and is relevant across Java and .Net (mostly how to expose way for crypto algorithms and how to wrap/unwrap keys) - please hold this PR until we have a clear way forward there (because it could impact public surface area)
Naveen will follow-up on this
Hi @FabianMeiswinkel, @j82w, @kirankumarkolli, now that the feedback has been addressed, please help review and close on this PR. Thanks! |
58ae8d8
cd8ac4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
This reverts commit b73ed61.
Pull Request Template
Description
Need this to GA the client-encryption feature.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber