Diagnostics: Adds total number of active clients information #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
j82w
reviewed
Feb 17, 2022
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosTraceDiagnostics.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientConfigurationTraceDatum.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/DefaultTracingTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Feb 17, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientConfigurationTraceDatum.cs
Outdated
Show resolved
Hide resolved
|
PR description is stale, please refresh. |
kirankumarkolli
previously approved these changes
Feb 17, 2022
sourabh1007
force-pushed
the
users/sourabhjain/activeclientcount
branch
from
1d0c5c9
to
8df1394
Compare
ealsur
reviewed
Feb 17, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ActiveClientDiagnosticTest.cs
Outdated
Show resolved
Hide resolved
j82w
previously approved these changes
Feb 22, 2022
j82w
reviewed
Feb 22, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientConfigurationTraceDatum.cs
Show resolved
Hide resolved
ealsur
reviewed
Feb 23, 2022
ealsur
reviewed
Feb 23, 2022
j82w
approved these changes
Feb 25, 2022
ealsur
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To Identify if a user is properly disposing of clients for certain cases., Adding
NumberOfActiveClientsinformation in request Diagnostics.Type of change
Closing issues
To automatically close an issue: closes #2589