Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientEncryption: Adds the use of Azure.Core interfaces in public surface #3050

Merged
merged 9 commits into from
Mar 3, 2022

Conversation

abhijitpai
Copy link
Contributor

Description

Use interfaces from Azure.Core.Cryptography for customers to provide the implementation used to wrap/unwrap the data encryption key instead of the existing custom wrapper interfaces created over Microsoft.Data.Encryption.Cryptography. This allows using the Azure.Security.KeyVault.Keys implementation for CMKs in Azure Key Vault and we no longer need the MDE specific Microsoft.Data.Encryption.AzureKeyVaultProvider.

Type of change

  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@abhijitpai abhijitpai changed the title ClientEncryption: Use Azure.Core interfaces in public surface ClientEncryption: Adds the use of Azure.Core interfaces in public surface Feb 24, 2022
Copy link
Member

@simplynaveen20 simplynaveen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Thanks @abhijitpai .
Two thing we noticed and we will notify the core team , that the resolver/builder design is not ideal , it is creating KeyEncryptionKeyClient every time even for same key via resolver resolve/build method.

@j82w j82w merged commit 6156c4c into master Mar 3, 2022
@j82w j82w deleted the users/abpai/azureCoreInterfaces branch March 3, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants