Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Line endings: Adds gitattribute to normalize line endings #3062

Merged
merged 4 commits into from
Mar 3, 2022

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Mar 3, 2022

Pull Request Template

Description

Several of the files have mixed line endings causing issues with PRs saying they changed the entire file instead of just 1 line. This is adding a gitattribute file that will force all the files to use the CRLF formatting. This also fixes all the .cs files to use the correct formatting.

Modeled after the Azure Core team version but added the CRLF formatting.
https://github.com/Azure/azure-sdk-for-net/blob/main/.gitattributes

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@j82w j82w changed the title [INTERNAL] Line endings: Add gitattribute to normalize line endings [INTERNAL] Line endings: Adds gitattribute to normalize line endings Mar 3, 2022
@github-actions github-actions bot dismissed their stale review March 3, 2022 15:53

All good!

.gitattribute Outdated Show resolved Hide resolved
kirankumarkolli
kirankumarkolli previously approved these changes Mar 3, 2022
@j82w j82w enabled auto-merge (squash) March 3, 2022 19:33
@j82w j82w merged commit af9b009 into master Mar 3, 2022
@j82w j82w deleted the users/jawilley/lineendings branch March 3, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants