-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Telemetry And Diagnostics : Adds VMId or Unique Id in payload #3100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vmId should be added to request diagnostics as well
289c549
to
35bf1c7
Compare
dc6e836
to
79f2c1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for few small comments
32fa208
to
51b9038
Compare
f435120
to
895ceeb
Compare
fc08df7
to
98ebd6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
Description
machineId
information in client telemetry payload and request diagnostics.a) For Azure Instance : it will be vmId from Azure Instance Metadata API call with prefix
vmId:
b) Otherwise:
i) It will have
hashedMachineId: + <hashedMachineName>
ii) If it throws exception,
uuid: <generated uuid>
Use Cases for Client Telemetry:
a) Helpful to identify if any particular machine is having issue.
b) We can corelate this information with Compute Kusto/Networking Team (any other team outside cosmos db sdk)
Use Cases for Request Diagnostics:
a) In case of vmid, We can corelate this information with Compute Kusto/Networking Team (any other team outside cosmos db sdk)
b) It will be helpful to identify if all the requests are coming from same machine or different machine. (if cx provides bunch of request diagnostics)
c) In case of uuid, this information won't be helpful much.
For Azure Instance:
Client Telemetry
Request Diagnostics
For Non-Azure Instance:
Client Telemetry
Request Diagnostics
Client Telemetry
Request Diagnostics
Type of change
Closing issues
To automatically close an issue: closes #3096