Upsert item: Fixes a bug causing session tokens for PKRangeId 0 to be overridden by session token for another partition on upserts #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y session token for another partition on upserts
FabianMeiswinkel
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur and
kirillg
as code owners
j82w
previously approved these changes
Mar 22, 2022
...osoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemSessionTokenTests.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Mar 22, 2022
j82w
approved these changes
Mar 22, 2022
ealsur
approved these changes
Mar 22, 2022
j82w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
TransportHandler.ProcessUpsertAsyncwas capturing session tokens even for throttled (or failed) requests. Because throttled requests (or 449/410) won't always have a PKRangeId header this resulted in session tokens for PKRangeId 0 being overridden with the session token of another partition. There is no reason to ever capture a session token on a 429, 449 or 410 - and it turned out there was also no need for the special-casing of upserts inTransportHandler.So, this PR is...
TransportHandlerNoSessionTokenCaptureForThrottledUpsertRequestsTestfailed without the change inTransportHandler- now succeeds)Type of change
Please delete options that are not relevant.