Query: Fixes invalid query text exception losing error details #3137

ealsur · 2022-04-08T22:49:58Z

Pull Request Template

Description

When the SDK is on Direct mode, the SDK attempts to generate the query plan locally (see https://docs.microsoft.com/en-us/azure/cosmos-db/sql/performance-tips-query-sdk?tabs=v3&pivots=programming-language-csharp#use-local-query-plan-generation). If it detects that the query is malformed, it returns a Bad Request (HTTP 400) exception.

The problem was that the code was using Monads and throwing the Monad exception, leaving the InnerException null and adding a lot of Monad related information to the exception Message that was irrelevant to the users, making the discovery of the actual parsing error very difficult.

The PR maintains the Stack Trace and Diagnostics, and adds the InnerException pointing to the real error, and reduces the clutter on the Message.

Original exception

Message

"Response status code does not indicate success: BadRequest (400); Substatus: 0; ActivityId: ; Reason: (Microsoft.Azure.Cosmos.Query.Core.Monads.ExceptionWithStackTraceException: TryCatch resulted in an exception. ---> Microsoft.Azure.Cosmos.Query.Core.Monads.ExceptionWithStackTraceException: TryCatch resulted in an exception. ---> Microsoft.Azure.Cosmos.Query.Core.Exceptions.ExpectedQueryPartitionProviderException: {\"errors\":[{\"severity\":\"Error\",\"location\":{\"start\":0,\"end\":9},\"code\":\"SC1001\",\"message\":\"Syntax error, incorrect syntax near 'selectttt'.\"}]}\r\n ---> System.Runtime.InteropServices.COMException (0x800A0B00): 0x800A0B00\r\n   --- End of inner exception stack trace ---\r\n   --- End of inner exception stack trace ---\r\n   at Microsoft.Azure.Cosmos.Query.Core.QueryPlan.QueryPartitionProvider.TryGetPartitionedQueryExecutionInfoInternal(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Bool
ean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount)\r\n   at Microsoft.Azure.Cosmos.Query.Core.QueryPlan.QueryPartitionProvider.TryGetPartitionedQueryExecutionInfo(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount)\r\n   at Microsoft.Azure.Cosmos.CosmosQueryClientCore.TryGetPartitionedQueryExecutionInfoAsync(SqlQuerySpec sqlQuerySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount, CancellationToken cancellationToken)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallb
ack callback, Object state)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)\r\n   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.ContinuationWrapper.Invoke()\r\n   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)\r\n   at System.Threading.Tasks.UnwrapPromise`1.TrySetFromTask(Task task, Boolean lookForOce)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessInnerTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessComplete
dOuterTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.Invoke(Task completingTask)\r\n   at System.Threading.Tasks.Task.RunOrQueueCompletionAction(ITaskCompletionAction completionAction, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task.FinishStageThree()\r\n   at System.Threading.Tasks.Task.FinishStageTwo()\r\n   at System.Threading.Tasks.Task.FinishSlow(Boolean userDelegateExecute)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\n   at System.Threading.Thread.StartCallback()\r\n\r\n   --- En
d of inner exception stack trace ---\r\n   at Microsoft.Azure.Cosmos.Query.Core.QueryPlan.QueryPartitionProvider.TryGetPartitionedQueryExecutionInfo(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount)\r\n   at Microsoft.Azure.Cosmos.CosmosQueryClientCore.TryGetPartitionedQueryExecutionInfoAsync(SqlQuerySpec sqlQuerySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount, CancellationToken cancellationToken)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Runti
me.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)\r\n   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.ContinuationWrapper.Invoke()\r\n   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)\r\n   at System.Threading.Tasks.UnwrapPromise`1.TrySetFromTask(Task task, Boolean lookForOce)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessInnerTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessCompletedOuterTask(Task task)\r\n   at System.Threading.T
asks.UnwrapPromise`1.Invoke(Task completingTask)\r\n   at System.Threading.Tasks.Task.RunOrQueueCompletionAction(ITaskCompletionAction completionAction, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task.FinishStageThree()\r\n   at System.Threading.Tasks.Task.FinishStageTwo()\r\n   at System.Threading.Tasks.Task.FinishSlow(Boolean userDelegateExecute)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\n   at System.Threading.Thread.StartCallback()\r\n);"

InnerException
null

StackTrace

at Microsoft.Azure.Cosmos.Query.Core.QueryPlan.QueryPartitionProvider.TryGetPartitionedQueryExecutionInfo(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount)\r\n   at Microsoft.Azure.Cosmos.CosmosQueryClientCore.TryGetPartitionedQueryExecutionInfoAsync(SqlQuerySpec sqlQuerySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount, CancellationToken cancellationToken)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuil
der`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)\r\n   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.ContinuationWrapper.Invoke()\r\n   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)\r\n   at System.Threading.Tasks.UnwrapPromise`1.TrySetFromTask(Task task, Boolean lookForOce)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessInnerTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessCompletedOuterTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.Invoke(Task comple
tingTask)\r\n   at System.Threading.Tasks.Task.RunOrQueueCompletionAction(ITaskCompletionAction completionAction, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task.FinishStageThree()\r\n   at System.Threading.Tasks.Task.FinishStageTwo()\r\n   at System.Threading.Tasks.Task.FinishSlow(Boolean userDelegateExecute)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\n   at System.Threading.Thread.StartCallback()\r\n

Diagnostics

{\"Summary\":{\"GatewayCalls\":{\"(200, 0)\":1}},\"name\":\"Typed FeedIterator ReadNextAsync\",\"id\":\"b27594ff-8a8d-4498-8e18-5cfb3a3a5148\",\"start time\":\"10:06:35:460\",\"duration in milliseconds\":3049.7607,\"data\":{\"Client Configuration\":{\"Client Created Time Utc\":\"2022-04-08T22:06:35.3311174Z\",\"NumberOfClientsCreated\":1,\"NumberOfActiveClients\":1,\"User Agent\":\"cosmos-netstandard-sdk/3.26.1|3.30.900|1|X64|Microsoft Windows 10.0.19044|.NET 6.0.3|N|\",\"ConnectionConfig\":{\"gw\":\"(cps:50, urto:10, p:False, httpf: False)\",\"rntbd\":\"(cto: 5, icto: -1, mrpc: 30, mcpe: 65535, erd: True, pr: ReuseUnicastPort)\",\"other\":\"(ed:False, be:False)\"},\"ConsistencyConfig\":\"(consistency: NotSet, prgns:[])\"},\"Query Correlated ActivityId\":\"a2e7d88d-5c61-4d80-9612-0f7846023674\"},\"children\":[{\"name\":\"Create Query Pipeline\",\"id\":\"114eb6d0-7d51-49c9-b3b1-d6038dfd456f\",\"start time\":\"10:06:35:487\",\"duration in milliseconds\":2128.8746,\"children\":[{\"name\":\"Get Container Properti
es\",\"id\":\"0e323e68-60e3-42d8-9583-b63cb0376b74\",\"start time\":\"10:06:35:490\",\"duration in milliseconds\":1841.3228,\"children\":[{\"name\":\"Get Collection Cache\",\"id\":\"68087684-8d35-40a4-837d-d974f7346681\",\"start time\":\"10:06:35:491\",\"duration in milliseconds\":1019.067,\"children\":[{\"name\":\"Waiting for Initialization of client to complete\",\"id\":\"5a7c153a-69f8-48b2-b19b-03a6f96edb96\",\"start time\":\"10:06:35:492\",\"duration in milliseconds\":1018.0061}]},{\"name\":\"Read Collection\",\"id\":\"ab66c5bb-5c95-42af-bd5f-94dbbac7b7b5\",\"start time\":\"10:06:36:584\",\"duration in milliseconds\":739.0342,\"data\":{\"Client Side Request Stats\":{\"Id\":\"AggregatedClientSideRequestStatistics\",\"ContactedReplicas\":[],\"RegionsContacted\":[],\"FailedReplicas\":[],\"AddressResolutionStatistics\":[],\"StoreResponseStatistics\":[],\"HttpResponseStats\":[{\"StartTimeUTC\":\"2022-04-08T22:06:36.6095348Z\",\"DurationInMs\":632.2959,\"RequestUri\":\"https://maquaran-custrepro-westus.documents
.azure.com/dbs/test/colls/test\",\"ResourceType\":\"Collection\",\"HttpMethod\":\"GET\",\"ActivityId\":\"488c4dab-f5f9-4a24-a9d5-8897fe0f6489\",\"StatusCode\":\"OK\"}]}}}]},{\"name\":\"Service Interop Query Plan\",\"id\":\"1dd4a168-6972-4296-977f-d5a6a45cf252\",\"start time\":\"10:06:37:338\",\"duration in milliseconds\":186.2282}]},{\"name\":\"POCO Materialization\",\"id\":\"03f9d450-1ec5-44a6-ae01-5b45636142e1\",\"start time\":\"10:06:38:357\",\"duration in milliseconds\":153.3713}]}

Exception after this PR

Message

"Response status code does not indicate success: BadRequest (400); Substatus: 0; ActivityId: ; Reason: ({\"errors\":[{\"severity\":\"Error\",\"location\":{\"start\":0,\"end\":9},\"code\":\"SC1001\",\"message\":\"Syntax error, incorrect syntax near 'selectttt'.\"}]});"

InnerException

Microsoft.Azure.Cosmos.Query.Core.Exceptions.ExpectedQueryPartitionProviderException: {"errors":[{"severity":"Error","location":{"start":0,"end":9},"code":"SC1001","message":"Syntax error, incorrect syntax near 'selectttt'."}]}

StackTrace

at Microsoft.Azure.Cosmos.Query.Core.QueryPlan.QueryPartitionProvider.TryGetPartitionedQueryExecutionInfo(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount)\r\n   at Microsoft.Azure.Cosmos.CosmosQueryClientCore.TryGetPartitionedQueryExecutionInfoAsync(SqlQuerySpec sqlQuerySpec, PartitionKeyDefinition partitionKeyDefinition, Boolean requireFormattableOrderByQuery, Boolean isContinuationExpected, Boolean allowNonValueAggregateQuery, Boolean hasLogicalPartitionKey, Boolean allowDCount, CancellationToken cancellationToken)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuil
der`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)\r\n   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)\r\n   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.ContinuationWrapper.Invoke()\r\n   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)\r\n   at System.Threading.Tasks.UnwrapPromise`1.TrySetFromTask(Task task, Boolean lookForOce)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessInnerTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.ProcessCompletedOuterTask(Task task)\r\n   at System.Threading.Tasks.UnwrapPromise`1.Invoke(Task comple
tingTask)\r\n   at System.Threading.Tasks.Task.RunOrQueueCompletionAction(ITaskCompletionAction completionAction, Boolean allowInlining)\r\n   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)\r\n   at System.Threading.Tasks.Task.FinishContinuations()\r\n   at System.Threading.Tasks.Task.FinishStageThree()\r\n   at System.Threading.Tasks.Task.FinishStageTwo()\r\n   at System.Threading.Tasks.Task.FinishSlow(Boolean userDelegateExecute)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)\r\n   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\n   at System.Threading.Thread.StartCallback()\r\n

Diagnostics

{\"Summary\":{\"GatewayCalls\":{\"(200, 0)\":1}},\"name\":\"Typed FeedIterator ReadNextAsync\",\"id\":\"cf35bebb-459c-40b0-a860-0fc9706f7107\",\"start time\":\"10:10:34:126\",\"duration in milliseconds\":1958.407,\"data\":{\"Client Configuration\":{\"Client Created Time Utc\":\"2022-04-08T22:10:33.8452038Z\",\"NumberOfClientsCreated\":1,\"NumberOfActiveClients\":1,\"User Agent\":\"cosmos-netstandard-sdk/3.26.1|3.30.900|1|X64|Microsoft Windows 10.0.19044|.NET 6.0.3|N|\",\"ConnectionConfig\":{\"gw\":\"(cps:50, urto:10, p:False, httpf: False)\",\"rntbd\":\"(cto: 5, icto: -1, mrpc: 30, mcpe: 65535, erd: True, pr: ReuseUnicastPort)\",\"other\":\"(ed:False, be:False)\"},\"ConsistencyConfig\":\"(consistency: NotSet, prgns:[])\"},\"Query Correlated ActivityId\":\"78e2f2b8-207e-41ed-91fc-b7699fa223a3\"},\"children\":[{\"name\":\"Create Query Pipeline\",\"id\":\"6fe5b3e9-821e-4e50-b104-3adeec910c78\",\"start time\":\"10:10:34:148\",\"duration in milliseconds\":1364.5434,\"children\":[{\"name\":\"Get Container Propertie
s\",\"id\":\"52e916fc-0f34-445b-b648-d3788672f0cb\",\"start time\":\"10:10:34:151\",\"duration in milliseconds\":1167.2648,\"children\":[{\"name\":\"Get Collection Cache\",\"id\":\"f24eaba6-6543-48f9-bcf3-ab5b7fffcf2c\",\"start time\":\"10:10:34:152\",\"duration in milliseconds\":658.9873,\"children\":[{\"name\":\"Waiting for Initialization of client to complete\",\"id\":\"f5b97719-1253-4d4e-8b50-fa35c81c1f96\",\"start time\":\"10:10:34:153\",\"duration in milliseconds\":657.4638}]},{\"name\":\"Read Collection\",\"id\":\"3efd2ea6-356c-478f-b8ad-0eb32086315e\",\"start time\":\"10:10:34:836\",\"duration in milliseconds\":474.7224,\"data\":{\"Client Side Request Stats\":{\"Id\":\"AggregatedClientSideRequestStatistics\",\"ContactedReplicas\":[],\"RegionsContacted\":[],\"FailedReplicas\":[],\"AddressResolutionStatistics\":[],\"StoreResponseStatistics\":[],\"HttpResponseStats\":[{\"StartTimeUTC\":\"2022-04-08T22:10:34.8656288Z\",\"DurationInMs\":395.9182,\"RequestUri\":\"https://maquaran-custrepro-westus.documents.a
zure.com/dbs/test/colls/test\",\"ResourceType\":\"Collection\",\"HttpMethod\":\"GET\",\"ActivityId\":\"b867a262-3ba3-486f-aeb4-3938ff3adf00\",\"StatusCode\":\"OK\"}]}}}]},{\"name\":\"Service Interop Query Plan\",\"id\":\"c6b5d1e3-3d6b-4f41-a8ca-e78bfcde9671\",\"start time\":\"10:10:35:322\",\"duration in milliseconds\":125.3667}]},{\"name\":\"POCO Materialization\",\"id\":\"3b2233d5-cfb2-41bd-a4c9-c0100cf562c0\",\"start time\":\"10:10:35:949\",\"duration in milliseconds\":135.2378}]}

Type of change

Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues

Closes #1910
Closes #2847

Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs

…-cosmos-dotnet-v3 into users/ealsur/qpfixbr

...latorTests/BaselineTest/TestBaseline/LinqAggregateFunctionBaselineTests.TestAggregateAvg.xml

neildsh · 2022-04-11T18:06:22Z

Great PR description Matias!

Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/QueryPlanRetrieverTests.cs

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTestsCommon.cs

* Fixing the exception * Throw right one * Right stack trace * tests * Changing to message * Updating contract baselines * Adding new test * Updating output generation * variable name

ealsur added 4 commits April 8, 2022 15:01

Fixing the exception

cd9ed42

Throw right one

1877a7a

Right stack trace

e2e3d3f

tests

8ffaab1

ealsur added bug Something isn't working QUERY labels Apr 8, 2022

ealsur requested review from khdang, sboshra, neildsh, kirankumarkolli, j82w, FabianMeiswinkel, kirillg and leminh98 as code owners April 8, 2022 22:49

Merge branch 'master' into users/ealsur/qpfixbr

2127276

j82w previously approved these changes Apr 9, 2022

View reviewed changes

j82w reviewed Apr 9, 2022

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs Outdated Show resolved Hide resolved

ealsur added 3 commits April 11, 2022 08:00

Changing to message

a6b4ca5

Updating contract baselines

b149dab

Merge branch 'users/ealsur/qpfixbr' of https://github.com/Azure/azure…

3bfbeb1

…-cosmos-dotnet-v3 into users/ealsur/qpfixbr

ealsur dismissed j82w’s stale review via 3bfbeb1 April 11, 2022 15:01

Adding new test

8559a63

j82w reviewed Apr 11, 2022

View reviewed changes

...latorTests/BaselineTest/TestBaseline/LinqAggregateFunctionBaselineTests.TestAggregateAvg.xml Show resolved Hide resolved

Updating output generation

b6095fb

j82w previously approved these changes Apr 11, 2022

View reviewed changes

neildsh reviewed Apr 11, 2022

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs Show resolved Hide resolved

ealsur mentioned this pull request Apr 11, 2022

Query: Avoid layering of TryCatch/Monads #3139

Open

neildsh reviewed Apr 11, 2022

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/QueryPlanRetrieverTests.cs Outdated Show resolved Hide resolved

neildsh reviewed Apr 11, 2022

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTestsCommon.cs Show resolved Hide resolved

neildsh previously approved these changes Apr 11, 2022

View reviewed changes

variable name

98f4bb5

ealsur dismissed stale reviews from neildsh and j82w via 98f4bb5 April 11, 2022 21:24

j82w approved these changes Apr 11, 2022

View reviewed changes

ealsur merged commit 1347d05 into master Apr 11, 2022

ealsur deleted the users/ealsur/qpfixbr branch April 11, 2022 22:27

neildsh mentioned this pull request Apr 21, 2022

Query: Fixes query plan via service interop to use custom serializer #3154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Query: Fixes invalid query text exception losing error details #3137

Query: Fixes invalid query text exception losing error details #3137

ealsur commented Apr 8, 2022 •

edited

Loading

neildsh commented Apr 11, 2022

Query: Fixes invalid query text exception losing error details #3137

Query: Fixes invalid query text exception losing error details #3137

Conversation

ealsur commented Apr 8, 2022 • edited Loading

Pull Request Template

Description

Original exception

Exception after this PR

Type of change

Closing issues

neildsh commented Apr 11, 2022

ealsur commented Apr 8, 2022 •

edited

Loading