Diagnostics: Adds request session token #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanvt
requested review from
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
Outdated
Show resolved
Hide resolved
imanvt
changed the title
j82w
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientSideRequestStatisticsTraceDatum.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientSideRequestStatisticsTraceDatum.cs
Outdated
Show resolved
Hide resolved
…ead of ISessionToken
j82w
reviewed
May 6, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
Outdated
Show resolved
Hide resolved
…equest-diagnostics
…stics' of https://github.com/Azure/azure-cosmos-dotnet-v3 into users/imanvt/3107-add-session-token-into-request-diagnostics
j82w
reviewed
May 9, 2022
...icrosoft.Azure.Cosmos.Tests/BaselineTest/TestBaseline/TraceWriterBaselineTests.TraceData.xml
Outdated
Show resolved
Hide resolved
j82w
reviewed
May 9, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientSideRequestStatisticsTraceDatum.cs
Outdated
Show resolved
Hide resolved
Can you please explain the scenario in PR description, why are we adding this information in request diagnostics? |
added 2 commits
May 9, 2022 12:29
…stics' of https://github.com/Azure/azure-cosmos-dotnet-v3 into users/imanvt/3107-add-session-token-into-request-diagnostics
j82w
previously approved these changes
May 9, 2022
ealsur
reviewed
May 9, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
May 9, 2022
ealsur
approved these changes
May 9, 2022
j82w
changed the title
j82w
deleted the
users/imanvt/3107-add-session-token-into-request-diagnostics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add Session Token into request diagnostics, which will simplify session consistency investigations.
Type of change
Closing issues
closes #3107