Diagnostics : Adds Continuation Token from PkRange cache #3180
Conversation
sourabh1007
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
sourabh1007
changed the title
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientSideRequestStatisticsTraceDatum.cs
Outdated
Show resolved
Hide resolved
|
Title says "Cancellation Token" is it supposed to be "ContinuationToken"? |
|
What's the scenario for continuation token? (Is it for PkRangeFeed Api's) |
sourabh1007
changed the title
It is always ContinuationToken only..Sorry for the typo and confusion. |
Yes..it is the same..I have put link of the issue in the PR description for more detail. |
sourabh1007
force-pushed
the
users/sourabhjain/logcontinuationToken
branch
from
f411bef to
1dfc08d
Compare
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientSideRequestStatisticsTraceDatum.cs
Outdated
Show resolved
Hide resolved
sourabh1007
changed the title
sourabh1007
force-pushed
the
users/sourabhjain/logcontinuationToken
branch
from
1dfc08d to
9f3fe57
Compare
sourabh1007
force-pushed
the
users/sourabhjain/logcontinuationToken
branch
from
0e3010f to
5df4038
Compare
sourabh1007
force-pushed
the
users/sourabhjain/logcontinuationToken
branch
from
8819fad to
5651586
Compare
...osoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemSessionTokenTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| this.jsonWriter.WriteObjectStart(); | ||
|
|
||
| this.jsonWriter.WriteFieldName("Previous Continuation Token"); |
There was a problem hiding this comment.
Should we use "PreviousContinuationToken"? similar as "BELatencyInMs", no space in between
Description
After this PR,
Right now,
NoOpTracehas been passed in most of the cases forPartitionKeyRangeCachecall. In future PRs, we will be removing NoOpTrace from these calls to get the proper diagnostics.Type of change
Closing issues
To automatically close an issue: closes #3167