Diagnostics: Adds Processor count into CosmosDiagnostics #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanvt
requested review from
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
ealsur
reviewed
May 16, 2022
Microsoft.Azure.Cosmos/src/Tracing/TraceData/ClientConfigurationTraceDatum.cs
Show resolved
Hide resolved
ealsur
reviewed
May 16, 2022
ealsur
reviewed
May 16, 2022
...Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientConfigurationDiagnosticTest.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
May 18, 2022
ealsur
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds Processor count into Client configuration section of diagnostics. Insufficient number of processors can cause high latency, so this will help identify those situations.
Type of change
Closing issues
closes #2978