CosmosClient Constructor: Fixes NullReferenceException when AzMetadata.Compute is null #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanvt
requested review from
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
j82w
reviewed
Jun 2, 2022
j82w
previously approved these changes
Jun 2, 2022
FabianMeiswinkel
previously approved these changes
Jun 2, 2022
j82w
approved these changes
Jun 2, 2022
j82w
changed the title
ealsur
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When AzMetadata.Compute is null for the VMMetadataApiHandler, the GetMachineId method does not work as intended. This PR fixes that to not allow a null reference to exist.
Type of change
Closing issues
closes #3237