Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosClientBuilder: Adds Warmup Option to Create/Initialize Containers #3257

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

imanvt
Copy link
Contributor

@imanvt imanvt commented Jun 8, 2022

Pull Request Template

Description

It is suggested to create a CosmosClient instance via the CosmosClientBuilder. The CosmosClient directly supports a warmup option for containers initialization, but the CosmosClientBuilder doesn't. This PR adds that as an option to reduce latency upon startup when creating a client using the CosmosClientBuilder.

Type of change

  • [] New feature (non-breaking change which adds functionality)

Closing issues

closes #3042

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@imanvt imanvt changed the title CosmosClientBuilder: Add Warmup Option to Create/Initialize Containers CosmosClientBuilder: Adds Warmup Option to Create/Initialize Containers Jun 8, 2022
@imanvt imanvt requested a review from ealsur June 8, 2022 19:42
@ealsur
Copy link
Member

ealsur commented Jun 8, 2022

@kirankumarkolli could you review the public API changes?

@ealsur ealsur merged commit dbbae92 into master Jun 9, 2022
@ealsur ealsur deleted the users/imanvt/3042-cosmosdbclientbuilder-warmup branch June 9, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CosmosDbClientBuilder should support warm up (like CreateAndInitializeContainersAsync())
3 participants