-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PREVIEW] AI Integration: Adds open telemetry support for most of the Operations #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
June 20, 2022 18:13
sourabh1007
changed the title
[PREVIEW] AI Integration: Adds Open telemetry Support for Point Operations
[PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point Operations
Jun 20, 2022
sourabh1007
changed the title
[PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point Operations
[Don't Review] [PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point Operations
Jun 20, 2022
sourabh1007
changed the title
[Don't Review] [PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point Operations
[Don't Review] [PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point/Stream Operations
Jun 22, 2022
sourabh1007
changed the title
[Don't Review] [PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point/Stream Operations
[PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point/Stream Operations
Jun 22, 2022
sourabh1007
changed the title
[PREVIEW] AI Integration: Adds open telemetry support for Container/Database/Point/Stream Operations
[PREVIEW] AI Integration: Adds open telemetry support for User/Permission/Container/Database/Point Item/Stream Item Operations
Jun 24, 2022
ealsur
reviewed
Jun 24, 2022
ealsur
reviewed
Jun 24, 2022
ealsur
reviewed
Jun 24, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 24, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 24, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Telemetry/OpenTelemetryTests.cs
Outdated
Show resolved
Hide resolved
sourabh1007
changed the title
[PREVIEW] AI Integration: Adds open telemetry support for User/Permission/Container/Database/Point Item/Stream Item Operations
[PREVIEW] AI Integration: Adds open telemetry support for most of the Operations
Jun 29, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryAttributes.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryCoreRecorder.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosBadReplicaTests.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good already - just left a few comments.
sourabh1007
force-pushed
the
users/sourabhjain/aipointoperations
branch
from
July 1, 2022 06:48
b3cb1e0
to
c4f0b7a
Compare
sourabh1007
force-pushed
the
users/sourabhjain/aipointoperations
branch
from
July 6, 2022 17:38
09dfc28
to
48bad70
Compare
ealsur
reviewed
Jul 6, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/Exceptions/ChangeFeedProcessorUserException.cs
Show resolved
Hide resolved
ealsur
reviewed
Jul 6, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryCoreRecorder.cs
Show resolved
Hide resolved
ealsur
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR
1. Open Telemetry has been enabled for following operations:
Database Operations
DatabaseInlineCore
CreateContainerAsync (3 Overloads)
CreateContainerIfNotExistsAsync (3 Overloads)
CreateContainerStreamAsync (2 Overloads)
DeleteAsync
DeleteStreamAsync
ReadAsync
ReadStreamAsync
ReadThroughputAsync--> need to revisit as it returns only int value (Not changing as part of this PR)
ReadThroughputAsync
ReplaceThroughputAsync
ReplaceThroughputAsync
UpsertUserAsync
CreateClientEncryptionKeyAsync
CreateUserAsync
CosmosClient
CreateDatabaseAsync(2 Overrides)
CreateDatabaseStreamAsync
ReadAccountAsync --> need to revisit as it returns Account Properties Object instead of response (NOT changing as part of this PR)
CreateDatabaseIfNotExistsAsync
Container Operations (
ContainerInlineCore
)ReadContainerAsync
ReadContainerStreamAsync
ReplaceContainerAsync
ReplaceContainerStreamAsync
DeleteContainerAsync
DeleteContainerStreamAsync
ReadThroughputAsync --> need to revisit as it returns only int value (Not changing as part of this PR)
ReadThroughputAsync (overload of above)
ReplaceThroughputAsync
ReplaceThroughputAsync
ReadThroughputIfExistsAsync
ReplaceThroughputIfExistsAsync
ReadManyItemsStreamAsync
ReadManyItemsAsync
GetFeedRangesAsync --> need to revisit as it returns only List of feedranges value (Not changing as part of this PR)
GetPartitionKeyRangesAsync --> need to revisit as it returns only List of feedranges value (Not changing as part of this PR)
Item Operations (Point/Stream) (
ContainerInlineCore
)CreateItemStreamAsync
CreateItemAsync
ReadItemStreamAsync
ReadItemAsync
UpsertItemStreamAsync
UpsertItemAsync
ReplaceItemStreamAsync
ReplaceItemAsync
DeleteItemStreamAsync
DeleteItemAsync
PatchItemStreamAsync (2 Overloads)
PatchItemAsync
DeleteAllItemsByPartitionKeyStreamAsync
ConflictInlineCore
DeleteAsync
ReadCurrentAsync
UserInlineCore.cs
CreatePermissionAsync
ReadAsync
ReplaceAsync
DeleteAsync
UpsertPermissionAsync
PermissionInlineCore
ReadAsync
ReplaceAsync
DeleteAsync
ChnageFeedIteratorCore
ReadNextAsync
ChangeFeedPartitionKeyResultSetIteratorCore
ReadNextAsync
ChangeFeedEstimatorIterator
ReadNextAsync
BatchCore
ExecuteAsync --> need to revisit as a separate PR. Right now not collecting request information and Response size.
ClientEncryptionKeyInlineCore
ReadAsync
ReplaceAsync
FeedIteratorInlineCore
ReadNextAsync
FeedIteratorInlineCore<T>
ReadNextAsync
ScriptsInlineCore
CreateStoredProcedureAsync
ReadStoredProcedureAsync
ReplaceStoredProcedureAsync
DeleteStoredProcedureAsync
ExecuteStoredProcedureAsync
ExecuteStoredProcedureStreamAsync
ExecuteStoredProcedureStreamAsync
CreateTriggerAsync
ReadTriggerAsync
ReplaceTriggerAsync
DeleteTriggerAsync
CreateUserDefinedFunctionAsync
ReadUserDefinedFunctionAsync
ReplaceUserDefinedFunctionAsync
DeleteUserDefinedFunctionAsync
2. An internal flag has been added to enable open telemetry feature in Tests
3. Added baseline tests for open telemetry
Follow up issues: #3317
#3323
#3324
#3325
#3326
Type of change